Closes #20564: Many-to-many pass-through port mappings#20851
Closes #20564: Many-to-many pass-through port mappings#20851
Conversation
…ing front/rear ports
There was a problem hiding this comment.
The only changes made in this file are to update the test data to use PortMappings. None of the test methods themselves have been significantly modified.
|
Aside from the incomplete items noted in the TODO list above, I believe this is ready for review. |
jeremystretch
requested review from
a team and
arthanson
and removed request for
a team
|
This is the Rear Ports detail view, it is showing "Rear Ports" as the included table, should be "Front Ports" |
|
We May want to move Rear Ports out of the right-hand-side to below all the other columns - with this demo data it is pushing connection and inventory items way down so not very usable. |
|
On cable trace in the Related Paths I think it would be useful to not link the current path, for example this one is showing the end path "xe-0/0/3" to "xe-0/0/3" but it is still linked in the table and not obvious which one you are on except by looking at the name in the trace box. Having the current one not be linked would just another nice UI indicator of which one. |
arthanson
left a comment
arthanson
left a comment
There was a problem hiding this comment.
Looks good - the main item is fixing the confusing "rear ports" reference, should be "front ports" on the rear ports detail page. Couple other suggested UI tweaks.
Agreed, but this improvement would be out of scope for #20564. Do you want to open a separate FR for it? |
2 participants
Closes: #20564
Note: Any changes made for FrontPort or RearPort are also made for their corresponding template models, FrontPortTemplate and RearPortTemplate, unless otherwise notes.
PortMappingmodel to map port & position pairs between FrontPorts and RearPortsmappingsrelation on both FrontPort & RearPortpositionsIntegerField on FrontPort to match the existingpositionsfield on RearPortrear_portForeignKey andrear_port_positionIntegerField from FrontPortfront_portson RearPortSerializerrear_portson FrontPortSerializercreate_port_mappings()function for this purposerear_portandrear_port_positioncolumns from FrontPortTablemappingscolumn to both FrontPortTable and RearPortTablefront_port_idfilter for RearPort and update FrontPort'srear_port_idfilterpositionsfilter for FrontPort and FrontPortTemplaterear_portfield on FrontPortType withmappingsmappingsto RearPortTypeTODO
Cable.from_origin()